Make PYBIND11_INTERNALS_VERSION 6 the default on all platforms.
#5512
Conversation
This file contains bidirectional Unicode text that may be interpreted or compiled differently than what appears below. To review, open the file in an editor that reveals hidden Unicode characters.
Learn more about bidirectional Unicode characters
henryiii
approved these changes
Feb 12, 2025
There was a problem hiding this comment.
I think it would be fine to make this pybind11 3, combined with the Python and CMake version bumps, and compiler bumps we've already added. That could also mean we could remove ABI <6, as a major version bump was supposed to be an ABI bump I believe. But regardless, I think this makes sense.
OK, thanks! Let's discuss separately. |
Sign up for free
to join this conversation on GitHub.
Already have an account?
Sign in to comment
Add this suggestion to a batch that can be applied as a single commit.
This suggestion is invalid because no changes were made to the code.
Suggestions cannot be applied while the pull request is closed.
Suggestions cannot be applied while viewing a subset of changes.
Only one suggestion per line can be applied in a batch.
Add this suggestion to a batch that can be applied as a single commit.
Applying suggestions on deleted lines is not supported.
You must change the existing code in this line in order to create a valid suggestion.
Outdated suggestions cannot be applied.
This suggestion has been applied or marked resolved.
Suggestions cannot be applied from pending reviews.
Suggestions cannot be applied on multi-line comments.
Suggestions cannot be applied while the pull request is queued to merge.
Suggestion cannot be applied right now. Please check back later.
Description
Make
PYBIND11_INTERNALS_VERSION 6the default on all platforms.Follow-on to
PYBIND11_PLATFORM_ABI_IDmodernizations under PRs #4953 and #5439.Rationale for this PR:
The
PYBIND11_PLATFORM_ABI_IDmodernizations under PRs 4953 and 5439 already created an ABI break (see below) in most situations. The only exception is when all of thePYBIND11_COMPILER_TYPEPYBIND11_STDLIB, andPYBIND11_BUILD_ABImacros (see here) are overriden explicitly. — This is assumed to be rare.Standardizing on
PYBIND11_INTERNALS_VERSION 6for all platforms is therefore assumed to cause few additional ABI breaks, but makes it much easier to reason about the pybind11 behavior, and it sets the stage for eventually purging old code:This PR intentionally does not remove the code for supporting
PYBIND11_INTERNALS_VERSIONs4and5. Therefore users can still override the default if necessary.After some transition period the code for supporting
PYBIND11_INTERNALS_VERSIONs4and5should be purged, especially because it is no longer exercised in the pybind11 GitHub Actions.Regarding the choice of version number for the next release: The ABI break is the only kind of break, and the additional features compared to the 2.13 release series are mostly incremental. Therefore @rwgk believes v2.14.0 is better as a version number than v3.0.0.
ABI break: Extensions built with e.g. pybind11 2.13 will not interoperate with extensions built with pybind11 2.14.
Note for completeness: PR #5296 greatly reduced the impact of changing the
PYBIND11_INTERNALS_VERSION(see PR description there). The ABI break due to PRs #4953 and #5439 is quite likely the last major pybind11 ABI break.Suggested changelog entry:
``PYBIND11_INTERNALS_VERSION 6`` is now the default on all platforms.